Skip to content

Conversation

my-git9
Copy link
Contributor

@my-git9 my-git9 commented Sep 22, 2025

imagePullSecrets is a required field when the user uses an encrypted private image repository.

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 07:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configuring imagePullSecrets in the Helm chart to enable pulling images from private encrypted repositories. The feature is implemented with both global and component-specific configurations, allowing flexible secret management across different chart components.

  • Adds imagePullSecrets configuration options at global and component levels
  • Implements a helper template to render imagePullSecrets blocks consistently
  • Applies imagePullSecrets to all deployment templates (VLLM, KV Cache Manager, Redis)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vllm-setup-helm/values.yaml Adds imagePullSecrets configuration fields for global and component-specific settings
vllm-setup-helm/templates/_helpers.tpl Implements helper template for rendering imagePullSecrets with fallback logic
vllm-setup-helm/templates/deployment.yaml Applies imagePullSecrets to VLLM deployment spec
vllm-setup-helm/templates/kv-cache-manager.yaml Applies imagePullSecrets to KV Cache Manager deployment spec
vllm-setup-helm/templates/redis-deployment.yaml Applies imagePullSecrets to Redis deployment spec

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: xin.li <[email protected]>
@my-git9 my-git9 requested a review from Copilot September 22, 2025 07:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vMaroon
Copy link
Member

vMaroon commented Sep 23, 2025

/lgtm
/approve

Thanks!

@github-actions github-actions bot added the lgtm label Sep 23, 2025
@github-actions github-actions bot merged commit f5ab47c into llm-d:main Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants