Skip to content

Conversation

vMaroon
Copy link
Member

@vMaroon vMaroon commented Sep 12, 2025

Summary

  • Use OWNERS and OWNERS_ALIASES for maintainer/reviewers maintenance + PROW permissions
  • Use CODEOWNERS for automatic PR assignment. Note that PROW's blunderbuss was not used since it does not support granular assignment (e.g., guygir for the preprocessing package)

Once team management is more convenient in llm-d (cc @Gregory-Pereira perhaps?), teams can be synced with OWNERS_ALIASES for CODEOWNERS to also reference them.

@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 19:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes code ownership and review assignment by introducing proper PROW-compatible ownership files and restructuring the CODEOWNERS file for automatic PR assignment.

  • Introduces OWNERS_ALIASES to define maintainer and reviewer groups
  • Updates OWNERS to use alias references instead of individual usernames
  • Restructures CODEOWNERS to focus on automatic PR assignment with granular package-specific assignments

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
OWNERS_ALIASES Defines maintainer and reviewer groups for PROW integration
OWNERS Updates approvers and reviewers to reference alias groups
CODEOWNERS Restructures for automatic PR assignment with clearer purpose
.licenserc.yaml Adds OWNERS_ALIASES to license check exclusions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +7 to +8
- llm-d-kv-cache-manager-maintainers
- llm-d-kv-cache-manager-reviewers
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maintainers group is listed in both approvers and reviewers sections. This creates redundancy since approvers typically have reviewer permissions by default. Consider removing the maintainers group from the reviewers list to avoid duplication.

Suggested change
- llm-d-kv-cache-manager-maintainers
- llm-d-kv-cache-manager-reviewers
- llm-d-kv-cache-manager-reviewers

Copilot uses AI. Check for mistakes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that is not true.

@nilig nilig self-requested a review September 12, 2025 19:31
Copy link
Collaborator

@nilig nilig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@nilig nilig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vMaroon vMaroon merged commit da66c05 into main Sep 12, 2025
2 checks passed
@vMaroon vMaroon deleted the pings branch September 12, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants