Skip to content

Conversation

yankay
Copy link
Collaborator

@yankay yankay commented Sep 12, 2025

This PR refactors and significantly expands the unit tests for the LRU token store in pkg/tokenization/prefixstore/lru_store_test.go:

  • Adds a helper function to set up test stores with configurable block sizes.
  • Introduces new test cases for partial mismatches and prefix matches, improving coverage of edge cases.

These changes improve the reliability and maintainability of the prefix store implementation by ensuring more scenarios are validated.

@vMaroon
Copy link
Member

vMaroon commented Sep 12, 2025

Nice, thanks!

/lgtm
/approve

Copy link

Cannot approve the pull request: Error: vMaroon is not included in the approvers role in the OWNERS file

Copy link

Cannot apply the lgtm label because Error: vMaroon is not included in the reviewers role in the OWNERS file

@vMaroon vMaroon merged commit ffdbb3d into llm-d:main Sep 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants