-
Notifications
You must be signed in to change notification settings - Fork 43
feat: make kvcache.Indexer as gRPC Service #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: make kvcache.Indexer as gRPC Service #109
Conversation
84899bc
to
23b5014
Compare
@vMaroon please take a look. |
Thanks @zhengkezhou1 - will review as soon as possible. |
fbc318d
to
be7d0ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a gRPC service interface for the existing kvcache.Indexer functionality, exposing it as a network service. It addresses issue #14 by creating a minimal but functional gRPC API wrapper around the core KV cache indexer.
- Added gRPC protobuf definitions for IndexerService with GetPodScores RPC method
- Implemented server and client examples demonstrating the service integration
- Updated dependencies to include gRPC and protobuf packages
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
go.mod | Added gRPC and protobuf dependencies, promoted dustin/go-humanize to direct dependency |
api/indexer.proto | Defines the gRPC service specification with GetPodScores method |
api/indexer.pb.go | Generated protobuf Go code for message types |
api/indexer_grpc.pb.go | Generated gRPC service stubs and client/server interfaces |
examples/kv_cache_index_service/server/server.go | Implements IndexerService wrapping kvcache.Indexer functionality |
examples/kv_cache_index_service/server/main.go | Server application with sample data initialization |
examples/kv_cache_index_service/client/main.go | Client example demonstrating service usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9f8581a
to
5ab481c
Compare
@vMaroon please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review - very packed couple of weeks. Thank you for handling this!
Signed-off-by: zhengkezhou1 <[email protected]>
5ab481c
to
5356188
Compare
Signed-off-by: zhengkezhou1 <[email protected]
} | ||
|
||
// Initial query - should be empty since no events have been published | ||
pods, err := indexerSvc.indexer.GetPodScores(ctx, testdata.Prompt, testdata.ModelName, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: #14
Main Changes
kvcache.Indexer
as a service.