feat(server): enables TLS mode #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
force-pushed
the
tls_listener
branch
3 times, most recently
from
d70f576 to
5f4be3f
Compare
This change is made to support environments that require HTTPS. The server can now run over HTTPS with either user-provided certs or self-signed ones. This is done through flags aligned with vLLM (`--ssl-certfile`, `--ssl-keyfile`). Additionally `--self-signed-certs` has been provided for self-signed certs. Signed-off-by: Bartosz Majsak <[email protected]>
bartoszmajsak
force-pushed
the
tls_listener
branch
from
5f4be3f to
b9d87b5
Compare
|
/lgtm /approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made to support environments that require HTTPS. The server can now run over HTTPS with either user-provided certs or self-signed ones.
This is done through flags aligned with vLLM (
--ssl-certfile,--ssl-keyfile). Additionally--self-signed-certshas been provided for self-signed certs.