Export palette in Write activity pop at the wrong place

[llaske]

Steps to reproduce:

• Launch Write activity with the Export palette not visible (because the screen is too small)
• Resize the screen to view the Export palette
• Click on the Export palette, it's displayed at the left of the screen

[prakashujjwal1010]

Well, I found this bug not only in write activity but also in other activities.
this bug is occuring because the updatePosition for palette is not getting called on every click for toolbuttons.
see the code from palette.js of sugar-web library

invoker.addEventListener('click', function (event) { if (!that.invoker.classList.contains("toolbutton")) { updatePosition(event.x, event.y); } that.toggle(); });

Solution

we can change the code of palette.js to
invoker.addEventListener('click', function (event) { if (!that.invoker.classList.contains("toolbutton")) { updatePosition(event.x, event.y); } else { updatePosition(); } that.toggle(); });

so just wants to ask is there any problem in changing sugar-web lib code And should we change it in other activities also?

[quozl]

If you fix it please also do so in https://github.com/sugarlabs/sugar-web

[llaske]

Hmmm. First send a PR for Write, then we could extend it to sugar-web in all activities.
Which activities have you tested?

[prakashujjwal1010]

I have tested Paint activity , Physics activity, constellation
see below for physics activity,

basically it will occur when the palette's position or display property gets changed.

[llaske]

Fixed in #808