wip: refactor to use comfystream.pipeline #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliteprox
force-pushed
the
feat/comfystream-pipeline
branch
from
fd14d5a to
adff001
Compare
eliteprox
commented
Apr 14, 2025
eliteprox
force-pushed
the
feat/comfystream-pipeline
branch
2 times, most recently
from
1356f0a to
75b2a2f
Compare
victorges
requested changes
Apr 29, 2025
Comment on lines
-84
to
-86
| out = await self.video_incoming_frames.get() | ||
| while out.frame.side_data.skipped: | ||
| out = await self.video_incoming_frames.get() |
There was a problem hiding this comment.
Don't we need this logic anymore?
There was a problem hiding this comment.
Don't we need this logic anymore?
The frame skipping logic is in comfystream here https://github.com/livepeer/comfystream/blob/e9b87bc7bc0adb32c5731f70b1e11e44c1f2e3c1/src/comfystream/pipeline.py#L169-L170, so this method already implements the logic internally
|
|
||
| @abstractmethod | ||
| async def put_video_frame(self, frame: VideoFrame, request_id: str): | ||
| async def put_video_frame(self, frame: VideoFrame): |
There was a problem hiding this comment.
This is a regression. The request_id is defined on the put not on the get.
There was a problem hiding this comment.
Thanks for pointing out the solution here, I have opened a PR to comfystream that will support passing an optional request_id into the frame side_data. Tested this solution successfully
eliteprox
force-pushed
the
feat/comfystream-pipeline
branch
from
75b2a2f to
10e9ffb
Compare
eliteprox
force-pushed
the
feat/comfystream-pipeline
branch
3 times, most recently
from
bb4d668 to
e9691da
Compare
This reverts commit 999d268.
eliteprox
force-pushed
the
feat/comfystream-pipeline
branch
from
e9691da to
131c2ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes use of the exported pipeline class from livepeer/comfystream#114
This change is dependent on livepeer/comfystream#176