Models docker not to be compressed #519
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/ai-runner-models.yaml:138
- [nitpick] Consider reviewing the YAML formatting for the 'outputs' setting; using a mapping format instead of a comma-separated string may improve clarity and ensure correct parsing.
outputs: type=image,compression=uncompressed
| context: . | ||
| platforms: linux/amd64 | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| push: true |
There was a problem hiding this comment.
Unconditionally setting 'push' to true may lead to images being pushed on pull request events. Please verify that this behavior is intended to avoid unintended deployments.
Suggested change
| push: true | |
| push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} |
pwilczynskiclearcode
force-pushed
the
models-without-compression
branch
6 times, most recently
from
0212381 to
fd1ea32
Compare
pwilczynskiclearcode
force-pushed
the
models-without-compression
branch
from
fd1ea32 to
e373f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.