Skip to content

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Feb 25, 2025

Remove the deprecated CLIPluginProtocol for v3.0.


Currently failing because we still need to upgrade AA: litestar-org/advanced-alchemy#399

@provinzkraut provinzkraut requested review from a team as code owners February 25, 2025 14:24
@github-actions github-actions bot added area/docs This PR involves changes to the documentation area/plugins This PR involves changes to the plugins area/private-api This PR involves changes to the privatized API Breaking 🔨 size: small type/feat labels Feb 25, 2025
@provinzkraut provinzkraut force-pushed the remove-cli-plugin-protocol branch from 3dded92 to 5580e4e Compare February 25, 2025 14:25
@provinzkraut provinzkraut force-pushed the remove-cli-plugin-protocol branch from 5580e4e to 3f06eda Compare February 25, 2025 14:27
@github-actions github-actions bot added area/asgi area/background-tasks area/channels area/ci This PR involves changes to the CI/Infra area/connection area/constants This PR involves changes to the constants area/contrib This PR involves changes to the contrib (Deprecated) area/controller area/datastructures area/dependencies This PR involves changes to the dependencies area/di area/dto This PR involves changes to the DTOs area/enums This PR involves changes to the enums area/events area/handlers This PR involves changes to the handlers area/kwargs and removed size: small labels Feb 25, 2025
@provinzkraut provinzkraut force-pushed the remove-cli-plugin-protocol branch from 2551419 to 8ea4267 Compare February 25, 2025 14:35
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@provinzkraut provinzkraut enabled auto-merge (squash) February 26, 2025 09:28
@github-actions github-actions bot added area/dependencies This PR involves changes to the dependencies size: medium and removed size: small labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (911ae03) to head (cb73644).
Report is 1 commits behind head on v3.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             v3.0    #4027      +/-   ##
==========================================
- Coverage   98.25%   98.25%   -0.01%     
==========================================
  Files         342      342              
  Lines       15437    15432       -5     
  Branches     1668     1668              
==========================================
- Hits        15168    15163       -5     
  Misses        133      133              
  Partials      136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut merged commit f635625 into v3.0 Feb 26, 2025
24 of 25 checks passed
@provinzkraut provinzkraut deleted the remove-cli-plugin-protocol branch February 26, 2025 09:36
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 2)
7 New Code Smells (required ≤ 3)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

provinzkraut added a commit that referenced this pull request Mar 8, 2025
provinzkraut added a commit that referenced this pull request May 6, 2025
provinzkraut added a commit that referenced this pull request May 6, 2025
provinzkraut added a commit that referenced this pull request Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies This PR involves changes to the dependencies area/docs This PR involves changes to the documentation area/plugins This PR involves changes to the plugins area/private-api This PR involves changes to the privatized API Breaking 🔨 pr/internal size: medium type/feat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants