Make Mint-Y slightly blue #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used
clefebvre
force-pushed
the
something-blue
branch
from
9415e1b to
9a2b024
Compare
clefebvre
force-pushed
the
something-blue
branch
from
9a2b024 to
f07ba11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is common practice in UI design. It's done on mobile, desktop and all over the web. Grey is rarely completely grey, it usually has a little bit more blue in it than red and green.
Take your color picker and look at the grey here on Github. It's not #f8f8f8, it's #f6f8fa. Firefox does that well, Google docs, Trello etc..
The reason this is done is to make grey slightly more metallic looking and appear more modern. Pure grey is neutral, it can be perceived as cold or warm based on its surroundings. By bumping the blue (or in the case of github both the green and the blue) we force it to look cold.
Here's an interesting discussion on the topic: https://www.reddit.com/r/UXDesign/comments/1cd40iz/why_apples_systemwebsite_grey_shades_always_lean/
Another reason this makes the UI look more modern is because this is done a lot nowadays all over the place, but it wasn't done so much 10 years ago. Like all new trends, if you stick to past standards, you end up looking old.
Interestingly libAdwaita also just did this. If you update your Flatpak libAdwaita applications you'll see they now use #222226 for dark and #ebebed for light. https://gitlab.gnome.org/GNOME/libadwaita/-/commit/304338c4c7ebfc0601692db608afdf0202e96d8a
Because there are many libAdwaita apps already in Flathub and since our own theme is already quite close to it in terms of colors, this PR aligns Mint-Y to use similar colors.
The difference on the light theme is extremely subtle. It probably wouldn't be noticed by someone who wasn't told this had been done. The headers go from #e8e8e8 to #ebebed.
The difference is more visible in the dark theme, which also affects dark apps and the panel and cinnamon clutter elements in the default theme. This one is going from #2b2b2b to #222226 and #404040 to #2e2e33. It looks more modern but also much softer than before.