Skip to content

Fix #74: Workaround for serde-indexed not supporting serde(skip) yet #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix #74: Workaround for serde-indexed not supporting serde(skip) yet #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions libwebauthn/src/proto/ctap2/model/client_pin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ pub struct Ctap2ClientPinRequest {
#[serde(skip_serializing_if = "Option::is_none")]
pub pin_hash_encrypted: Option<ByteBuf>,

#[serde(skip_serializing)]
#[serde(skip_serializing_if = "always_skip")]
pub unused_07: (),

#[serde(skip_serializing)]
#[serde(skip_serializing_if = "always_skip")]
pub unused_08: (),

/// permissions (0x09)
Expand Down Expand Up @@ -237,3 +237,9 @@ pub struct Ctap2ClientPinResponse {
#[serde(skip_serializing_if = "Option::is_none")]
pub uv_retries: Option<u32>,
}

// Required by serde_indexed, as serde(skip) isn't supported yet:
// https://github.com/trussed-dev/serde-indexed/pull/14
fn always_skip(_v: &()) -> bool {
true
}
Loading