Update solo clone with build fix #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
soloclone to include AlfioEmanueleFresta/solo@c12e6c7.Fixes an occasional build error building
solo:The root cause is commit e8d0ad5e7cf2f8bd5a57aae8e5e8b69d3816474c, part of solokeys/solo1#121, which removes an extra argument from
ctap_initbut didn't updatepc/device.c.Note upstreaming PR has been blocked for a while - solokeys/solo1#577. IMO we should eventually migrate to Solo2, with FIDO2 support, rather than spend more time on solo1.