Skip to content

Conversation

@AlfioEmanueleFresta
Copy link
Member

Updates the solo clone to include AlfioEmanueleFresta/solo@c12e6c7.

Fixes an occasional build error building solo:

  make failed: Output { status: ExitStatus(unix_wait_status(512)), stdout: "cc -O2 -fdata-sections -ffunction-sections -fcommon -g -I../ -I./fido2/ -I./pc -I../pc -I./tinycbor/src -DAES256=1  -DSOLO_EXPERIMENTAL=1 -DDEBUG_LEVEL=1   -c -o pc/device.o pc/device.c\n", stderr: "pc/device.c: In function ‘device_init’:\npc/device.c:256:5: error: too many arguments to function ‘ctap_init’; expected 0, have 1\n  256 |     ctap_init(1);\n      |     ^~~~~~~~~ ~\nIn file included from ./fido2/storage.h:10,\n                 from ./fido2/device.h:10,\n                 from pc/device.c:20:\n./fido2/ctap.h:389:6: note: declared here\n  389 | void ctap_init();\n      |      ^~~~~~~~~\nmake: *** [<builtin>: pc/device.o] Error 1\n" }

The root cause is commit e8d0ad5e7cf2f8bd5a57aae8e5e8b69d3816474c, part of solokeys/solo1#121, which removes an extra argument from ctap_init but didn't update pc/device.c.

Note upstreaming PR has been blocked for a while - solokeys/solo1#577. IMO we should eventually migrate to Solo2, with FIDO2 support, rather than spend more time on solo1.

Copy link
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AlfioEmanueleFresta AlfioEmanueleFresta merged commit 8c606aa into master Jul 14, 2025
4 checks passed
@AlfioEmanueleFresta AlfioEmanueleFresta deleted the solo-fix branch July 14, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants