Skip to content

chore(app/trace-collector): remove Default bounds #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

chore(app/trace-collector): remove Default bounds #3651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linkerd/app/src/trace_collector/otel_collector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ where
S: GrpcService<BoxBody> + Clone + Send + 'static,
S::Error: Into<Error>,
S::Future: Send,
S::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
S::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
<S::ResponseBody as Body>::Error: Into<Error> + Send,
{
let (span_sink, spans_rx) = mpsc::channel(crate::trace_collector::SPAN_BUFFER_CAPACITY);
Expand Down
4 changes: 2 additions & 2 deletions linkerd/opencensus/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pub async fn export_spans<T, S>(client: T, node: Node, spans: S, metrics: Regist
where
T: GrpcService<BoxBody> + Clone,
T::Error: Into<Error>,
T::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
T::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
<T::ResponseBody as Body>::Error: Into<Error> + Send,
S: Stream<Item = ExportSpan> + Unpin,
{
Expand All @@ -49,7 +49,7 @@ impl<T, S> SpanExporter<T, S>
where
T: GrpcService<BoxBody>,
T::Error: Into<Error>,
T::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
T::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
<T::ResponseBody as Body>::Error: Into<Error> + Send,
S: Stream<Item = ExportSpan> + Unpin,
{
Expand Down
4 changes: 2 additions & 2 deletions linkerd/opentelemetry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub async fn export_spans<T, S>(
) where
T: GrpcService<BoxBody> + Clone,
T::Error: Into<Error>,
T::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
T::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
<T::ResponseBody as Body>::Error: Into<Error> + Send,
S: Stream<Item = ExportSpan> + Unpin,
{
Expand All @@ -66,7 +66,7 @@ impl<T, S> SpanExporter<T, S>
where
T: GrpcService<BoxBody> + Clone,
T::Error: Into<Error>,
T::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
T::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
<T::ResponseBody as Body>::Error: Into<Error> + Send,
S: Stream<Item = ExportSpan> + Unpin,
{
Expand Down
Loading