-
Notifications
You must be signed in to change notification settings - Fork 384
Add glm4.1v model support #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+732
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…propriate kernel functions
…el_to_glm4v function
…iger_kernel_to_instance_for_glm4v
…_kernel_to_glm4v function
…nditionalGeneration in test_mini_models
…alGeneration in test files
Found
|
@Tcc0403 FIxed with modify atol to 2e-2 |
lancerts
approved these changes
Aug 19, 2025
@shimizust Find problem in
I have done the fix on branch |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for GLM4.1V (GLM-4 Vision) models to the Liger Kernel #854
https://huggingface.co/zai-org/GLM-4.1V-9B-Thinking
This model have been merged in huggingface/transformers#38431
Testing Done
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence