Cancel in-progress but out-of-date GPU actions #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tyler-romero
changed the title
tyler-romero
force-pushed
the
tyler/cancel-in-progress-gpu-actions
branch
from
6bcd695 to
ff4dbb2
Compare
shimizust
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When updating a PR branch, a lot of concurrent CICD actions can be triggered. This creates a backlog and it takes time for the tests to actually get around to running on the most recent commit. Github makes it easy to cancel in-progress actions when new actions are trigged within a group. This will help avoid wasting GPU time running CICD on out of date commits.
Avoids cancelations on main, so that a complete CICD history is available there.
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence