Add proper attribution to egui authors. #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Feb 26, 2024
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2023 the Vello Authors | |||
| // Copyright 2021 the egui Authors and Vello Authors | |||
There was a problem hiding this comment.
The name used in egui's (MIT) license is:
Copyright (c) 2018-2021 Emil Ernerfeldt [email protected]
Maybe we should ask the author for their preference?
There was a problem hiding this comment.
The file in question was mostly written by Ivo Vollrath as seen in egui#306. Beyond that, there have been other contributors.
Given that there are multiple contributors and that the original file doesn't have a header at all, I think it's fine to reference them as egui Authors.
DJMcNab
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi touch example should have a clearer attribution to the original authors. The licenses still match.