Don't manually flatten curves for which the control points are strictly within the tolerance threshold #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly within the tolerance threshold
tomcur
reviewed
Sep 14, 2025
|
I've suggested two tighter (and cheaper to compute) bounds that I believe to be correct. |
tomcur
approved these changes
Sep 14, 2025
Co-authored-by: Tom Churchman <[email protected]>
|
Nice! Yes I also figured that there probably is a way to generate an even tighter bbox, but lacked the maths skills to figure it out. 😄 |
|
Really impressive, this gives yet another pretty significant speed boost on top of what was initially introduced in this PR! |
|
Here's the comparison to main now: 
|
|
Not bad at all! |
tomcur
added a commit
to tomcur/kurbo
that referenced
this pull request
Sep 14, 2025
This is a branchless calculation of a point-onto-line-segment projection. Also marks the method `#[inline]`. I started looking at this because of the math we introduced in linebender/vello#1214. This might allow us to introduce some tighter bounds there without introducing additional branching. This should be useful here regardless of whether the above happens.
|
I've opened linebender/kurbo#505, which may allow us to introduce tighter bounds. The idea would be to test whether the control points are very close to their projection onto the chord/line segment defined by the Bezier end points, rather than just close to the end points. Edit: see #1216. |
tomcur
added a commit
to tomcur/kurbo
that referenced
this pull request
Sep 19, 2025
This is a branchless calculation of a point-onto-line-segment projection. Also marks the method `#[inline]`. I started looking at this because of the math we introduced in linebender/vello#1214. This might allow us to introduce some tighter bounds there without introducing additional branching. This should be useful here regardless of whether the above happens.
github-merge-queue bot
pushed a commit
to linebender/kurbo
that referenced
this pull request
Sep 19, 2025
This is a branchless calculation of a point-onto-line-segment projection. Also marks the method `#[inline]` and adds some testing. I started looking at this because of the math we introduced in linebender/vello#1214. This might allow us to introduce some tighter bounds there without introducing additional branching. This should be useful here regardless of whether the above happens. --------- Co-authored-by: jneem <[email protected]>
flaviotore
added a commit
to flaviotore/kurbo
that referenced
this pull request
Oct 9, 2025
This is a branchless calculation of a point-onto-line-segment projection. Also marks the method `#[inline]` and adds some testing. I started looking at this because of the math we introduced in linebender/vello#1214. This might allow us to introduce some tighter bounds there without introducing additional branching. This should be useful here regardless of whether the above happens. --------- Co-authored-by: jneem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revival from an older PR. Confirmed to give a decent speed boost for 8x8 and 16x16 shapes.