-
Notifications
You must be signed in to change notification settings - Fork 2.2k
sever+lncfg: add sweepr config #6868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
53861b7
to
0586c95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactor!
Just a few thoughts around the safety aspect of this.
Can we make these configurable only with like an itest build flag? I feel like users will footgun themselves if they can configure something like |
Nice, I've run into some issues w/ this in the past when a sweep actually comes after some target event, and then needs to backoff, which causes a test failure or some non-deterministic behavior. |
0586c95
to
a6d09d6
Compare
Probably shouldn't put more changes than needed in this PR, so the other config options are now removed. Also does this mean Still thinking about the RPC server, or at least creating a new method to allow fetching the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐊
Needs a rebase! |
a6d09d6
to
50487c6
Compare
Done! |
This PR adds the ability to customize sweeper config, which is needed to set up special cases for our itest. This can also be useful to customize the sweeper behavior.
We may also consider making a RPC server for sweeper to have better control over the sweeping process.