-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Open
Labels
P2should be fixed if one has timeshould be fixed if one has timeenhancementImprovements to existing features / behaviourImprovements to existing features / behaviourfeesRelated to the fees paid for transactions (both LN and funding/commitment transactions)Related to the fees paid for transactions (both LN and funding/commitment transactions)inbound feeChanges related to inbound routing feeChanges related to inbound routing feeintermediateIssues suitable for developers moderately familiar with the codebase and LNIssues suitable for developers moderately familiar with the codebase and LNwire protocolEncoding of messages for the communication between nodesEncoding of messages for the communication between nodes
Description
In #6703 the new inbound fee field is added. However, it isn't added directly to the struct, instead the caller must always manually copy the field into the opaque data field, and also must always manually parse it out the other end. We should make this new field uniform with the other TLC fields by adding it directly within the struct. While we're at it, we can also morph it into tlv.OptionalRecord
.
Metadata
Metadata
Assignees
Labels
P2should be fixed if one has timeshould be fixed if one has timeenhancementImprovements to existing features / behaviourImprovements to existing features / behaviourfeesRelated to the fees paid for transactions (both LN and funding/commitment transactions)Related to the fees paid for transactions (both LN and funding/commitment transactions)inbound feeChanges related to inbound routing feeChanges related to inbound routing feeintermediateIssues suitable for developers moderately familiar with the codebase and LNIssues suitable for developers moderately familiar with the codebase and LNwire protocolEncoding of messages for the communication between nodesEncoding of messages for the communication between nodes