Add test vectors for option_anchors_zero_fee_htlc_tx #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
t-bast
reviewed
Aug 29, 2022
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 30, 2022
As specified in lightning/bolts#1018
|
ACK bcd452e, eclair agrees with those test vectors. Just need to fix the markdown link and we should be good to go. |
t-bast
approved these changes
Aug 30, 2022
27 tasks
27 tasks
26 tasks
26 tasks
30 tasks
28 tasks
28 tasks
27 tasks
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Dec 16, 2022
27 tasks
28 tasks
28 tasks
26 tasks
ellemouton
reviewed
Feb 22, 2023
There was a problem hiding this comment.
See #1056 for 2 changes that I think apply here too. Other than those 2 things, LGTM!
These are the same test vectors as those found under Appendix F, except that each HTLC has a zero fee transaction instead, resulting in a signature change.
|
Nice catch! Confirmed |
26 tasks
|
ACK 77eca9c, eclair works fine with the latest changes, thanks @wpaulino and @ellemouton! |
t-bast
approved these changes
Feb 28, 2023
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Feb 28, 2023
Add latest changes from lightning/bolts#1018
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Feb 28, 2023
Add latest changes from lightning/bolts#1018 Add latest fixes from lightning/bolts#1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the integration of
option_anchors_zero_fee_htlc_txforrust-lightning, I noticed that the test vectors were only for the originaloption_anchorscommitment format, which is also the case for BOLT-3.These are the same test vectors as those found under Appendix F, except that each HTLC has a zero fee transaction instead, resulting in a signature change.