Painter: scaling and transformation implementation (WANT_TRANSFORM=1) #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-base of PR #215 authored by @nstbayless . Main differences are related to the featureflag table, makefile behaviors, and various improvements to unit tests to better handle various potential error conditions. (all things added to main branch, but which create conflicts and required a rebase)
make WANT_TRANSFORM=1(this is default behavior)The feature is implemented using software logic and should be functioning properly on any/all platforms. It has been enabled by default, and is not expected to cause build errors or runtime issues, but can be disabled per platform with
WANT_TRANSFORM=0on a case-by-case basis. Performance of the feature, if used extensively, may be a concern depending on target platform.