Skip to content

Switch straight file I/O to VFS #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Switch straight file I/O to VFS #415

merged 1 commit into from
May 12, 2022

Conversation

phcoder
Copy link
Contributor

@phcoder phcoder commented Apr 17, 2022

This is needed for future use of e.g. Android storage SDK and windows UWP

Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! This is so cool! Didn't think of making a PhysFS wrapper for the vfs. Nice work!

@RobLoach
Copy link
Member

The altnerative would be to port all the file system functions over to using VFS instead https://github.com/libretro/libretro-chailove/blob/master/src/love/filesystem.cpp

@phcoder
Copy link
Contributor Author

phcoder commented Apr 20, 2022

The altnerative would be to port all the file system functions over to using VFS instead https://github.com/libretro/libretro-chailove/blob/master/src/love/filesystem.cpp

I don't feel like rewriting this file. If you want to do it, be my guest

This is needed for future use of e.g. Android storage SDK and windows UWP
@RobLoach RobLoach merged commit 66c021b into libretro:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants