Skip to content

skip_to.page_index not handled correctly #1613

@drobotk

Description

@drobotk

I've been testing this and there seems to still be some bug; I don't have a good repro but sometimes when hopping between albums/singles librespot plays the wrong thing, from not even the correct context. Logs show the new warning added by this PR but with the fallback index being 0. I'm going to try to get a repeatable scenario to share here.

Originally posted by @drobotk in #1599 (comment)

You seem to have found a case where the page_index is provided, I never encountered that before. I have a guess how to handle it tho thanks to your provided command snippet.

Originally posted by @photovoltex in #1599 (comment)

So the second issue isn't an easy fix as simply providing a fallback index... It probably makes more sense to limit this PR for now to the initial problem and offload the second issue into a separate topic.

A wrong behavior is more acceptable currently then something that prevents playback entirely.

Originally posted by @photovoltex in #1599 (comment)

@drobotk Could you create a new issue for the second issue you encountered here? It's worth fixing but would take some more time.

Originally posted by @photovoltex in #1599 (comment)

🚀

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions