Add Function to Enable Application Layer to Send Direct Control Messages

[thep2p]

Description

Proposal: Introduce a new function, SendControl, to the GossipSubRouter that allows the application layer to send direct control messages to a peer. This feature will primarily be used to develop finer-grained testing. Flow blockchain currently uses this feature quite extensively.

Proposed Function

// SendControl dispatches the given set of control messages to the given peer.
func (gs *GossipSubRouter) SendControl(p peer.ID, ctl *pb.ControlMessage, msgs ...*pb.Message) bool {
    out := rpcWithControl(msgs, ctl.Ihave, ctl.Iwant, ctl.Graft, ctl.Prune)
    return gs.sendRPC(p, out)
}

Sample implementation on my forked version.

Rationale

Adding this function does not break encapsulation drastically. It is available at the router-level, meaning it is only accessible if the application layer creates a router and passes it to a pubsub instance, rather than creating a gossipsub instance directly. This ensures controlled usage and maintains the integrity of the encapsulation.

Benefits

• Enables finer-grained testing.
• Provides more control for application layer developers.
• Maintains encapsulation integrity by limiting accessibility.

I can make the PR upon a soft approval.

[vyzo]

In principle this is fine, as it can allow application specific extensions to the protocol; this is useful for testing and early adoption as a path to standarization.
It is also in line with the philosophy of extensibility in the protocol.

However, i think that just sending control messages is insufficient. We also need a way to process incoming custom control messages.

[thep2p]

In principle this is fine, as it can allow application specific extensions to the protocol; this is useful for testing and early adoption as a path to standarization.
It is also in line with the philosophy of extensibility in the protocol.

Thanks, I'll then proceed with the PR.

We also need a way to process incoming custom control messages.

I believe processing incoming messages has already been implemented through the RPC inspector set by the application layer, as shown in this link: #509. Are you considering a different functionality?

[vyzo]

Oh right, i forgot!
No, i think it is sufficient.

[thep2p]

Created the PR: #562

[thep2p]

@vyzo a gentle reminder for this issue; the PR is ready pending a review; thanks! #562

[vyzo]

ah sorry, i forgot!

[thep2p]

Is it possible to have a tagged release of the master head (inclusive of #562)?

[vyzo]

sure, will make a patch release.