🔥 Remove clang-tidy again #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-tidy is very annoying to work with in cmake. Adding any sort of flags that it doesn't understand results in breakages everywhere. Rather than deal with clang-tidy, I'll push developers to call clangd-tidy directly. And have CI execute clangd-tidy as well. clangd-tidy runs clang-tidy via clangd which strips away all commands not meant for LLVM.
kammce
force-pushed
the
remove-clang-tidy-again
branch
from
2c20b93 to
991eaf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidy is very annoying to work with in cmake. Adding any sort of flags that it doesn't understand results in breakages everywhere.
Rather than deal with clang-tidy, I'll push developers to call clangd-tidy directly. And have CI execute clangd-tidy as well. clangd-tidy runs clang-tidy via clangd which strips away all commands not meant for LLVM.