libbpf-rs: minor fixes suggested by linter #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theihor
force-pushed
the
clippy-fixes
branch
3 times, most recently
from
156393e to
8d916ce
Compare
anakryiko
reviewed
Apr 11, 2025
libbpf-rs/src/btf/mod.rs
Outdated
| @@ -630,7 +630,7 @@ impl<'btf> BtfType<'btf> { | |||
| let int = types::Int::try_from(skipped).unwrap(); | |||
| Ok(Ord::min( | |||
| ptr_size, | |||
| NonZeroUsize::new(((int.bits + 7) / 8).into()).unwrap(), | |||
| NonZeroUsize::new(usize::from(int.bits.div_ceil(8))).unwrap(), | |||
There was a problem hiding this comment.
int.bits.div_ceil(8).into() ?
There was a problem hiding this comment.
It's explicit vs implicit cast, right? With into() the type is figured out by compiler?
Anyways...
There was a problem hiding this comment.
yes, and I've seen Daniel using .into() everywhere, which is why I'm pointing this out, this seems to be more idiomatic
clippy report: https://github.com/libbpf/libbpf-rs/actions/runs/14391135733/job/40358223316 Signed-off-by: Ihor Solodrai <[email protected]>
clippy report: https://github.com/libbpf/libbpf-rs/actions/runs/14391650754/job/40359765259 Signed-off-by: Ihor Solodrai <[email protected]>
|
thanks for quick fixes! back to green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippy compalined here: https://github.com/libbpf/libbpf-rs/actions/runs/14391135733/job/40358223316