CI: Update rtdv3 verify and merge workflows #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwagantall
force-pushed
the
update-rtdv3
branch
from
443ab50 to
cd046c7
Compare
tykeal
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Doing what you're doing isn't going to be conducive to projects that do not want to use this as a required workflow across their organization (for instance, ODL doesn't not dictate that this job runs across their org, but some projects may use it)
Also, while reviewing this change I realized that the rtd-verify job is doing a verify, which always uses a Gerrit Change, but the change is going to be merged at this point and it should be validating on the branch head... not certain how to reconcile that properly.
Given the changes that I'm requesting, you also need to make sure that the checkout action in use also adds in the following with:
repository: ${{ inputs.TARGET_REPO }}
cd046c7 to
ba409c6
Compare
tykeal
requested changes
Sep 1, 2023
Allow the rtdv3 workflows to be used as required or be used at the repository level. Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall
force-pushed
the
update-rtdv3
branch
from
ba409c6 to
efeb1cd
Compare
jwagantall
changed the title
tykeal
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the rtdv3 workflows to be used as required or be used at the repository level.