Skip to content

Conversation

textGamex
Copy link
Contributor

@textGamex textGamex commented Jun 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

add NavigationView Doc:

  • Set initial page
  • NavigationView with MVVM Pattern Explanation

Other information

@github-actions github-actions bot added documentation Improvements or additions to documentation PR Pull request labels Jun 10, 2024
@textGamex
Copy link
Contributor Author

Should the example code in the documentation be concise or complete?

@textGamex textGamex changed the title Doc: Update the document content. Doc: supplement the document content. Jun 12, 2024
@textGamex textGamex marked this pull request as ready for review June 12, 2024 18:02
@textGamex textGamex requested a review from pomianowski as a code owner June 12, 2024 18:02
@pomianowski
Copy link
Member

Should the example code in the documentation be concise or complete?

I think it should be simple with links to sample programs. In RC 4 the samples directory will contain more code examples

@textGamex
Copy link
Contributor Author

Should the example code in the documentation be concise or complete?

I think it should be simple with links to sample programs. In RC 4 the samples directory will contain more code examples

So is this pull request inappropriate?

@pomianowski pomianowski merged commit c2afe6c into lepoco:development Jul 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation PR Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants