Feat: Add dynamic {problems_pluralize} variable #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `{problems_pluralize}` variable to the `replaceMap` in `src/activity.ts`.
This variable dynamically resolves to "problem" or "problems" based on the total number of problems detected, allowing for more natural language in the user's status.
The `{problems_count}` variable is now derived from a `totalProblems` constant for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the handling of problem count pluralization in status messages and refactors related code for better readability and maintainability.
Improvements to status message pluralization:
package.json: Updated the default value ofvscord.status.problems.textto include{problems_pluralize}, allowing dynamic pluralization of the word "problem" based on the count.Code refactoring for problem count handling:
src/activity.ts: Introduced atotalProblemsvariable to centralize the calculation of the total problem count, replacing duplicate logic in thereplaceMap.src/activity.ts: Added a new placeholder{problems_pluralize}to thereplaceMap, dynamically setting it to "problem" or "problems" based on the value oftotalProblems.