Add configuration option to suppress RPC connection error notifications #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhayper
requested changes
May 27, 2025
src/controller.ts
Outdated
| return; | ||
| } | ||
|
|
||
| editor.statusBarItem.text = "$(search-refresh) Reconnect to Discord Gateway";4 |
There was a problem hiding this comment.
oh damn… I was wondering what the emoji comment means.
Took some time until I understood 😅
MrMinemeet
force-pushed
the
av/setting-suppress-RPC_COULD_NOT_CONNECT
branch
from
508587f to
9149faf
Compare
Useful if Discord is not permanently running (e.g. no auto start-up)
MrMinemeet
force-pushed
the
av/setting-suppress-RPC_COULD_NOT_CONNECT
branch
from
9149faf to
a4a5905
Compare
|
The change in the controller.ts shrunk a bit because of some other refactoring |
|
It shrunk quite a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setting in config to suppress the
RPC: RPC_COULD_NOT_CONNECTerror.Useful if Discord is not permanently running (e.g. no auto start-up)