fix(predictions): normalize paths outside of project dir #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcusber this should fix the issue you are experiencing, would you kindly confirm? |
|
@leonardochaia Works as expected! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-affected works by comparing the output of
git diffwith the output of MSBuild.Predictions.Basically, it needs to match the files that have changed with the files that are owned by each MSBuild Project.
For the comparison to works, paths must be normalized, we use
Path.GetFullPathto do so.This pr fixes the normalization of referencing paths outside of the project directory. The normalization was being done for relative paths only, this PR takes care of fixing it.
Fixes #93