Support SLNX by using Microsoft.VisualStudio.SolutionPersistence #124
Conversation
nicholass-alcidion
force-pushed
the
support-slnx
branch
2 times, most recently
from
f5a664b to
61d502e
Compare
|
|
||
| if (serializer is null) throw new NotImplementedException($"Filtering by {options.FilterFilePath} is not yet implemented"); | ||
|
|
||
| var solution = serializer.OpenAsync(options.FilterFilePath, CancellationToken.None).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
it would probably be better to go through the full async/await way that getting the awaiter and result
src/DotnetAffected.Core/ProjectDiscovery/SolutionFileProjectDiscoverer.cs
Outdated
Show resolved
Hide resolved
|
Looking forward to get this merged |
nicholass-alcidion
force-pushed
the
support-slnx
branch
3 times, most recently
from
1634c78 to
3f8885b
Compare
|
Any update on this? @leonardochaia do you have some time to review this? |
|
I tested this and it's working for me. Great addition. |
|
Hi all, thanks for this! will get merged. Looks like we'll eventually need to refactor IProjectDiscoverer to be async. |
|
@nicholass-alcidion could you kindly push test cases for slnx? Thank you! |
Yea, can and will do |
nicholass-alcidion
force-pushed
the
support-slnx
branch
from
3f8885b to
1452391
Compare
|
I have added tests where I think it is appropriate to add tests based on what I could find for traditional SLN Please let me know if any additional tests are needed, and if you could point me in the direction of what you would be looking for also, that would be awesome. Thanks for taking the time to review. |
|
Hi @nicholass-alcidion , @TheFireCookie , thank you very much for your contribution - sorry I couldn't take a look sooner. I'll cut a pre-release this week with these and other changes. Kind regards, |
Resolves #123
This PR adds support for using SLNX files with --filter-file-path