Working Windows (MSVC) build #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er flags, delete gui_win32.cpp (Removing the GUI due to compiler errors and the intent to build a new QT/text based monitor console)
code 1 when no parameters are given. When exit code 1 is given, the CI build fails.
- warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 2 has type 'size_t' - consider using '%zd' in the format string
Owner
|
Nice! I currently have a Windows VM with Visual Studio up and running (originally for the purpose of some university assignment), so I'm able to test it myself :) |
lenticularis39
approved these changes
Jan 22, 2021
Owner
lenticularis39
left a comment
lenticularis39
left a comment
There was a problem hiding this comment.
Seems to run fine (NetBSD installer boots), more testing can be done after merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #22, these commits fix the build on Windows in Visual Studio 2019.
Build config:
Running up until the SRM prompt:
I did remove the Win32_gui, as said in the commit messages, due to compiling errors and the intent to replace the gui with a more simh-like monitor console.
The github actions build now builds an .exe file you can try yourself.