GitHub actions build #26
Conversation
|
I do see that my branch missed the recent thread changes, now with those changes the osx build also fails... |
RaymiiOrg
force-pushed
the
github_actions_build
branch
3 times, most recently
from
0798f5d to
f92248b
Compare
|
I've updated the branch (rebase on current main) and fixed up the test running. Removed -Werror, but left -Wall so that the builds don't fail. OS X and Windows are allowed to fail. Windows has to be fixed up and for OS X I'll create a seperate merge request with a make_unique c++ 11 version. |
|
Rebased on current master, should be ready to check for review. |
RaymiiOrg
force-pushed
the
github_actions_build
branch
from
1b6d50a to
d205180
Compare
…acts. This workflow file builds AXPbox on every available github runner platform: - OS X 10.15 - Ubuntu 20.04 (GCC & Clang) - Windows Server 2019 (MSVC 16) It also runs the (currently only one) tests. Once a build is finished successfully, the resulting executable is uploaded to github and can later be downloaded. Filename includes the build date, example: 'AXPbox-linux-clang-2020-11-12T0512'.
Change IP address to domain name, since I'm not sure if that IP will always be part of my website (underlying servers change often). Added if check for travis/gh actions, did not want to disturb the current travis flow.
…/osx to fail We do want to see all issues, but don't let the build fail on them.
Test path cwd for github
…the test for a tr error message
Fix tr: Illegal byte sequence on OS X
RaymiiOrg
force-pushed
the
github_actions_build
branch
from
582b922 to
ffffb8e
Compare
now the test scripts work.
RaymiiOrg
force-pushed
the
github_actions_build
branch
from
442ef73 to
c12cff5
Compare
|
Rebased again on latest master, fixed up the OS X tests. @lenticularis39 how do you feel about this pull request? |
lenticularis39
left a comment
lenticularis39
left a comment
There was a problem hiding this comment.
Looks good, thank you for working on this!
I think we can merge it now as it is, perhaps only with the Windows build disabled so it doesn't always report an error in the build because of it.
I'll continue on in a other branch for that.
|
I've removed the windows build. Will continue on in another branch, but that doesn't have to clutter up this pull request and all subsequent builds. |
|
OK, merging this :) |
2 participants
Discussed a bit already in #22 , I've created a github actions workflow file, which builds axpbox on all platforms supported by the github runners (linux clang/gcc, os x and msvc). If the build succeeds, the resulting binary is uploaded. This binary can be downloaded by users or can later be used to make a "github release".
Currently the linux gcc and windows builds fail, but fixing that should be a different branch IMHO. (Which is why the run currently fails)