Fix malformed eval background color #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daedsidog
force-pushed
the
eval-bg-color-fix
branch
from
b20ffad to
ed65715
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
compute-evaluated-background-colorproducing a malformed color string.Also makes the highlight color darken instead of lighten when evaluating on light light themes.
It appears that the
compute-evaluated-background-colorfunction worked only through luck because it seems okay on most themes. On my theme, however, which had a pitch-black background color, the evaluation highlight looked really bad:This PR corrects the issue, but it may be necessary to change the values used in the function in the future because now it probably won't look as it looked before on some themes.