Skip to content

Conversation

jfaz1
Copy link
Contributor

@jfaz1 jfaz1 commented Jul 14, 2024

This adds some minor QoL changes to untracked files in legit status:

  • Show top-level list of files/directories inside of an untracked directory
  • Fix an error when trying to display untracked file contents for binaries

@vindarel
Copy link
Collaborator

Nice, LGTM and it works fine.

Did you rebase on master? Looks like this branch is a bit behind. Also something is strange on my side, could you rebase?

I am experiencing failures with "(ql:quickload "lem/legit")" on lem-init.lisp, even if it loads properly 🤔

@vindarel
Copy link
Collaborator

vindarel commented Jul 15, 2024

testing:

  • press Enter on a subdirectory of the untracked sectiond and I get an error: "the value of PATHNAME is NIL…"

(related to another PR, not this one I guess)

@jfaz1 jfaz1 force-pushed the legit-binary-error branch from 3312653 to df9861d Compare July 15, 2024 21:30
@vindarel vindarel merged commit ae9945f into lem-project:main Jul 15, 2024
@jfaz1
Copy link
Contributor Author

jfaz1 commented Jul 15, 2024

@vindarel Went ahead and rebased, let me know if that fixes the issue for you?

Whoops I was fixing the directory issue, I'll push up another PR when I sort that one out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants