Skip to content

Conversation

BierLiebHaber
Copy link
Contributor

@BierLiebHaber BierLiebHaber commented May 24, 2024

A comment on discord mentioned that strings as argument-descriptors are sub optimal, to which I agree.
This merge-request overhauls the define-command macro so that it accepts both old-style string descriptors, as well as list argument-descriptors.

The following descriptors were added:
:universal, :universal-1, :universal-nil, :string, :number, :num, :buffer, :other-buffer, :file, :new-file and :region
with :universal-1 and :num being aliases of :universal and :number respectively.

I also added some documentation to the existing :splice descriptor and exposed the extremely helpful comment in the command-function as a doc-string.

@cxxxr
Copy link
Member

cxxxr commented May 25, 2024

I think it's very nice.

By the way, I would like to avoid preparing num, what do you think?
I think we'll want str, too, and there's no end to it.

@BierLiebHaber
Copy link
Contributor Author

I agree. If people want to type less they can still use the string-descriptors.

@cxxxr cxxxr merged commit 97c049c into lem-project:main May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants