-
Notifications
You must be signed in to change notification settings - Fork 481
[new feat] add --serve-html-path param in server target #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think it would be better to keep this as a separate repository, like many other UIs powered by sd.cpp. |
I second that. It would also help if server had something like a |
How about adding the width, height, and steps parameters? If these changes look good, I’d be happy to open a separate PR for them. And I completely understand the strategy of separating frontend and backend services! That said, I’d like to suggest a simple HTML page (just basic API calling) to:
It’d require minimal maintenance, just like FastAPI’s auto-docs or llama.cpp’s debug page. |
At present, all of these parameters can be specified either in the prompt via |
I agree with this approach. |
Oh! Sorry for the redundant work. |
The code has been revised based on the comments. Currently, the front-end can be specified via a --serve-html-path option. Please review it. |
My work is as follows: