Implement gerrit scm #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladjadj
reviewed
Feb 20, 2025
internal/scm/gerrit/gerrit.go
Outdated
Comment on lines
54
to
69
| if project.State != "ACTIVE" { | ||
| log.Debug("Skipping repository since state is not ACTIVE") | ||
| continue | ||
| } |
There was a problem hiding this comment.
I think it's possible to filter directly in the ProjectOptions right ?
There was a problem hiding this comment.
I didn't see any option to filter state directly with ProjectOptions : https://github.com/andygrunwald/go-gerrit/blob/master/projects.go#L185
Seems possible directly using Gerrit Rest API, but go-gerrit didn't implement it yet 😃
dacofr
force-pushed
the
implement-gerrit-scm
branch
from
5f571a6 to
229827a
Compare
dacofr
force-pushed
the
implement-gerrit-scm
branch
from
229827a to
2b07a2f
Compare
dacofr
force-pushed
the
implement-gerrit-scm
branch
from
7a50322 to
e381bd0
Compare
dacofr
force-pushed
the
implement-gerrit-scm
branch
from
12dec00 to
9ae9be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
VersionControllerinterface with dummy behaviour (TL;DR :return nil, errors.New("implement me"))go-gerritlibGetRepositorieswith search based on Regex (cf https://gerrit-review.googlesource.com/Documentation/rest-api-projects.html#list-projects)GetPullRequestsandGetPullRequestsMergePullRequestandClosePullRequestCreatePullRequestandUpdatePullRequest, just to be able to return anscm.PullRequestobjectWill not be implemented