Skip to content

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 1, 2022

Summary

  • Adds support for Python 3.10
  • Monkey patches collections module to support Python 3.10

References

Fixes #9392


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some existentials doubts, but the code looks good and tests pass perfectly, so ready to be included in a new release

@rtibbles rtibbles merged commit e260724 into learningequality:release-v0.15.x May 2, 2022
@rtibbles rtibbles deleted the python3.10 branch May 2, 2022 15:37
@rtibbles rtibbles added the changelog Important user-facing changes label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Important user-facing changes TODO: needs review Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants