-
Notifications
You must be signed in to change notification settings - Fork 817
[DO NOT MERGE] KTable height - QA for KDS PR #1136 #13795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LianaHarris360
wants to merge
4
commits into
learningequality:develop
from
LianaHarris360:usertable-loader
Closed
[DO NOT MERGE] KTable height - QA for KDS PR #1136 #13795
LianaHarris360
wants to merge
4
commits into
learningequality:develop
from
LianaHarris360:usertable-loader
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Artifacts
|
AlexVelezLl
reviewed
Sep 29, 2025
kolibri/plugins/facility/assets/src/views/users/common/UsersTable.vue
Outdated
Show resolved
Hide resolved
AlexVelezLl
reviewed
Sep 29, 2025
kolibri/plugins/facility/assets/src/views/users/common/UsersTable.vue
Outdated
Show resolved
Hide resolved
AlexVelezLl
reviewed
Sep 29, 2025
kolibri/plugins/facility/assets/src/views/users/common/UsersTable.vue
Outdated
Show resolved
Hide resolved
AlexVelezLl
reviewed
Sep 29, 2025
kolibri/plugins/facility/assets/src/views/users/common/UsersTable.vue
Outdated
Show resolved
Hide resolved
96ee3d4 to
3995b15
Compare
4 tasks
9e03d37 to
4c75a7a
Compare
pcenov
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LianaHarris360 - I confirm that the table height remains consistent, no regressions observed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APP: Facility
Re: Facility App (user/class management, facility settings, csv import/export, etc.)
DEV: frontend
P1 - important
Priority: High impact on UX
SIZE: small
SIZE: very small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a QA PR for the Kolibri Design System PR KTable: Set min height during loading to prevent table height inconsistencies @radinamatic @pcenov
Testing checklist:
Before:
After:
Fast 4G Network:
Fast4G.mov
3G Network:
3G.mov