User Table Style Updates #13743
Merged
User Table Style Updates #13743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Facility
Build Artifacts
|
nucleogenesis
force-pushed
the
user-table-misc-polish
branch
from
d6b8a70 to
7406977
Compare
nucleogenesis
commented
Sep 19, 2025
| <KPageContainer | ||
| class="flex-column" | ||
| :style="{ maxHeight: pageContentHeight + 24 + 'px' }" | ||
| :style="{ maxHeight: pageContentHeight + 24 + 'px', padding: '2em 2em 1em' }" |
There was a problem hiding this comment.
Locked this padding in w/ Tomiwa on a call
Comment on lines
+34
to
+38
| appearanceOverrides: { | ||
| type: Object, | ||
| required: false, | ||
| default: null, | ||
| }, |
There was a problem hiding this comment.
We should probably do this in all of our *AppBarPage components and establish it as a convention for page-specific styling for each plugin.
kolibri/plugins/facility/assets/src/views/users/common/UsersTable.vue
Outdated
Show resolved
Hide resolved
LianaHarris360
approved these changes
Sep 23, 2025
nucleogenesis
force-pushed
the
user-table-misc-polish
branch
from
5bf2464 to
e20852c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Misc updates to the padding & various styles on the user table page.
At a high level, for review: