Skip to content

Conversation

Rob23oba
Copy link
Contributor

@Rob23oba Rob23oba commented Oct 8, 2025

This PR fixes getHexNumSize to consider underscores. Previously, only the amount of bytes was counted, making it output 9 for 1234_abcd instead of the actual number of digits, which is 8.

@github-actions github-actions bot added the changelog-language Language features and metaprograms label Oct 8, 2025
@Rob23oba Rob23oba marked this pull request as ready for review October 8, 2025 22:25
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 9, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f9e140838e5fb12f0726de36bcdf451eb08559fe --onto 54c6efea95a0d478f2659632749035962b1f4d8d. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-09 00:05:40)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase f9e140838e5fb12f0726de36bcdf451eb08559fe --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-09 00:05:41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants