-
Couldn't load subscription status.
- Fork 690
feat: adds acceptSelector and modified selectors
#10667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds acceptSelector and modified selectors
#10667
Conversation
300ef1a to
38475c9
Compare
acceptSelector and modified the signal selector to be used more than one.acceptSelector and modified the signal selector to be used more than one
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
38475c9 to
daf892e
Compare
acceptSelector and modified the signal selector to be used more than oneacceptSelector and modified selectors.
acceptSelector and modified selectors.acceptSelector and modified selectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have some theses for these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after addressing the last comment.
This PR adds more selectors for TCP and Signals.
It also fixes a problem with
Selectorsthat they cannot be closures over a promise, otherwise it causes the waiter promise to never be dropped.