-
Notifications
You must be signed in to change notification settings - Fork 677
fix: make .congr_simp theorems private #10656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
!bench |
Failed to find a commit to compare against. |
!radar |
Failed to find a commit to compare against. |
Here are the benchmark results for commit 767663f. Benchmark Metric Change
====================================================================
- Init size bytes .olean 4.3%
- Init.Data.BitVec.Lemmas wall-clock 35.4% (53.3 σ)
- big_deceq_rec branch-misses 2.2% (23.0 σ)
- grind_ring_5.lean branch-misses 3.4% (30.4 σ)
- mut_rec_wf branch-misses 4.4% (29.2 σ)
- riscv-ast.lean branch-misses 3.9% (22.9 σ)
- simp_bubblesort_256 branch-misses 6.1% (20.3 σ)
- stdlib congr simp thm 71.8% (40.7 σ)
- stdlib number of imported bytes 2.2%
- stdlib size bytes .olean 2.8% |
!radar |
Benchmark results for 767663f against 24c86fc are in! @Kha |
Given the regressions, this will need some further adjustments to preserve sharing while avoiding the name clash issues. |
767663f
to
124f573
Compare
!radar |
Benchmark results for 124f573 against fbfb075 are in! @Kha |
!bench |
Benchmark results for bb0b792 against fbfb075 are in! @Kha |
Here are the benchmark results for commit bb0b792. Benchmark Metric Change
====================================================
- Init size bytes .olean 1.1%
- stdlib blocked (unaccounted) 6.6% (49.0 σ)
- stdlib congr simp thm 41.0% (27.8 σ)
+ stdlib maxrss -1.6% (-26.3 σ) |
bb0b792
to
acc3d5b
Compare
Fixes #10613