change(regenerate_dashboard.yml): only fetch aggregate data #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies both the webpage generation (no dependency on the .json files) and the code, conceptually. It allows removing all filling in of placeholders. Further clean-ups left for the future include - remove a now-duplicate method in generate_assignment_page - removing the BasicPRInformation class, as its content is essentially a subset of the aggregate PR information. Landing this depends on PR data being updated reliably: not yet.
This should be significantly faster, as downloading all the raw data becomes superfluous. As a by-product, we can also skip installing curl or jq. Move the webpage generation into a separate workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be significantly faster, as downloading all the raw data
becomes superfluous. As a by-product, we can also skip installing curl or jq.
And move the webpage generation into a separate workflow again.
Depends on #70; do not land!