Migration of own-learning card from sistent to cloud-ui #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FaheemOnHub <[email protected]>
ritzorama
approved these changes
Aug 4, 2025
aabidsofi19
reviewed
Aug 4, 2025
| }; | ||
|
|
||
| const LearningCard: React.FC<Props> = ({ |
There was a problem hiding this comment.
lets rename this component to ContentOverviewCard , and the tutorial prop to curriculaContent and use the types from schemas . couse count to unitCount and word "courses" to units . the create new content needs to be separate content only reusing the base card styling and not a part of this component .
There was a problem hiding this comment.
i guess these changes need to be done in cloud ui though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Initially the ownLearningcard was placed in sistent as it was not much different from other learning cards but now it includes a modal and follows a stepper component which does not makes it suitable to place in sistent.
Signed commits