Skip to content

Conversation

DRSchlaubi
Copy link
Contributor

This PR updates the dependencies to their latest versions

the most relevant is kotlinx.datetime, which removed kotlinx.datetime.Instant which was removed by kotlin.time.Instant

This means that long term consumers of the Kotlin types have to switch from Error.timestamp to Error.instant in the mean type deprecated accessors are present

I've run japicmp to compare the 2 APIs and the only change is component1(), which is only relevant for Kotlin plugins and none of the public plugins uses it

API Comparison

***! MODIFIED CLASS: PUBLIC FINAL dev.arbjerg.lavalink.protocol.v4.Error  (not serializable)
        ===  CLASS FILE FORMAT VERSION: 61.0 <- 61.0
        ===  UNCHANGED CONSTRUCTOR: PUBLIC Error(kotlinx.datetime.Instant, int, java.lang.String, java.lang.String, java.lang.String, java.lang.String)
                +++  NEW ANNOTATION: kotlin.Deprecated
                        +++  NEW ELEMENT: message=Replaced by the new instant variable, which uses kotlin.time.Instant rather than kotlinx.datetime.Instant (+)
        +++  NEW CONSTRUCTOR: PUBLIC(+) Error(kotlin.time.Instant, int, java.lang.String, java.lang.String, java.lang.String, java.lang.String)
        ***! MODIFIED METHOD: PUBLIC FINAL kotlin.time.Instant (<-kotlinx.datetime.Instant) component1()
        ===  UNCHANGED METHOD: PUBLIC FINAL dev.arbjerg.lavalink.protocol.v4.Error copy(kotlinx.datetime.Instant, int, java.lang.String, java.lang.String, java.lang.String, java.lang.String)
                +++  NEW ANNOTATION: kotlin.Deprecated
                        +++  NEW ELEMENT: message=Replaced by the new instant variable, which uses kotlin.time.Instant rather than kotlinx.datetime.Instant (+)
        +++  NEW METHOD: PUBLIC(+) FINAL(+) dev.arbjerg.lavalink.protocol.v4.Error copy(kotlin.time.Instant, int, java.lang.String, java.lang.String, java.lang.String, java.lang.String)
        +++  NEW METHOD: PUBLIC(+) FINAL(+) kotlin.time.Instant getInstant()
        ***  MODIFIED ANNOTATION: kotlin.Metadata
                ===  UNCHANGED ELEMENT: xi=48
                ***  MODIFIED ELEMENT: mv=2,2,0 (<- 2,1,0)
                ===  UNCHANGED ELEMENT: k=1
                ***  MODIFIED ELEMENT: d1=?Z&#xA;???&#xA;???&#xA;?&#xA;???&#xA;???&#xA;?&#xA;???&#xA;???&#xA;?&#xA;???&#xA;?&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;?&#xA;???&#xA;???????? =2?0?:?&lt;=BN??????0?j?`?¢???????????&#x9;0???????0&#x9;???&#xA;??0??&#xA;????????0????&#xD;??0???????0?¢??????B=????????0???????0&#x9;???&#xA;??0??&#xA;????????0????&#xD;??0???????0?¢??????BU????????0&#x9;????????0???????0&#x9;???&#xA;????0?????????0????&#xD;????0?????????0?????????0?¢??????JF?&quot;??0?2???????0?2???????0&#x9;2????&#xA;??0?2&#xA;????????0?2????&#xD;??0?2???????0?H?J??)??0?j?`?¢???????????&#x9;0?HÆ?J&#x9;?*??0&#x9;HÆ?J&#x9;?+??0?HÆ?J??,????0?HÆ?J&#x9;?-??0?HÆ?J&#x9;?.??0?HÆ?JZ?&quot;??0?2???????0?j?`?¢???????????&#x9;0?2???????0&#x9;2????&#xA;??0?2&#xA;????????0?2????&#xD;??0?2???????0?HÆ?J??/??002??1????0?HÖ?J&#x9;?2??0&#x9;HÖ?J&#x9;?3??0?HÖ?J%?4??052??6??0?2??7??082??9??0:H?¢???;R/????0?j?`?¢???????????&#x9;0?8?X??¢??&#xA;?????????????R?????0&#x9;¢??&#xA;???????R??&#xA;??0?¢??&#xA;???????R???????0?¢??&#xA;???????R??&#xD;??0?¢??&#xA;???? ??R?????0?¢??&#xA;????!??R!?#??0?8FX???¢??&#xA;??&apos;?(???$?????%?&amp;¨?&gt; (<- ?R&#xA;???&#xA;???&#xA;?&#xA;???&#xA;???&#xA;?&#xA;???&#xA;???&#xA;?&#xA;???&#xA;?&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;???&#xA;?&#xA;???&#xA;???????? 32?0?:?23BN??????0?j?`?¢???????????&#x9;0???????0&#x9;???&#xA;??0??&#xA;????????0????&#xD;??0???????0?¢??????BU????????0&#x9;????????0???????0&#x9;???&#xA;????0?????????0????&#xD;????0?????????0?????????0?¢??????J?????0?j?`?¢???????????&#x9;0?HÆ?J&#x9;????0&#x9;HÆ?J&#x9;? ??0?HÆ?J??!????0?HÆ?J&#x9;?&quot;??0?HÆ?J&#x9;?#??0?HÆ?JZ?$??0?2???????0?j?`?¢???????????&#x9;0?2???????0&#x9;2????&#xA;??0?2&#xA;????????0?2????&#xD;??0?2???????0?HÆ?J??%??0&amp;2??&apos;????0?HÖ?J&#x9;?(??0&#x9;HÖ?J&#x9;?)??0?HÖ?J%?*??0+2??,??0?2??-??0.2??/??00H?¢???1R$????0?j?`?¢???????????&#x9;0?¢??&#xA;???????R?????0&#x9;¢??&#xA;???????R??&#xA;??0?¢??&#xA;???????R???????0?¢??&#xA;???????R??&#xD;??0?¢??&#xA;???????R?????0?¢??&#xA;???????¨?4)
                ***  MODIFIED ELEMENT: d2=Ldev/arbjerg/lavalink/protocol/v4/Error;,,instant,Lkotlin/time/Instant;,Lkotlinx/serialization/Serializable;,with,Ldev/arbjerg/lavalink/protocol/v4/serialization/TimestampSerializer;,Ldev/arbjerg/lavalink/protocol/v4/serialization/Timestamp;,status,,error,,trace,message,path,&lt;init&gt;,(Lkotlin/time/Instant;ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V,Lkotlinx/datetime/Instant;,(Lkotlinx/datetime/Instant;ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V,seen0,serializationConstructorMarker,Lkotlinx/serialization/internal/SerializationConstructorMarker;,(ILkotlin/time/Instant;ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V,getInstant$annotations,()V,getInstant,()Lkotlin/time/Instant;,getStatus,()I,getError,()Ljava/lang/String;,getTrace,getMessage,getPath,copy,timestamp,getTimestamp$annotations,getTimestamp,()Lkotlinx/datetime/Instant;,timestamp$delegate,Lkotlin/Lazy;,component1,component2,component3,component4,component5,component6,equals,,other,hashCode,toString,write$Self,,self,output,Lkotlinx/serialization/encoding/CompositeEncoder;,serialDesc,Lkotlinx/serialization/descriptors/SerialDescriptor;,write$Self$protocol,$serializer,Companion,protocol (<- Ldev/arbjerg/lavalink/protocol/v4/Error;,,timestamp,Lkotlinx/datetime/Instant;,Lkotlinx/serialization/Serializable;,with,Ldev/arbjerg/lavalink/protocol/v4/serialization/TimestampSerializer;,Ldev/arbjerg/lavalink/protocol/v4/serialization/Timestamp;,status,,error,,trace,message,path,&lt;init&gt;,(Lkotlinx/datetime/Instant;ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V,seen0,serializationConstructorMarker,Lkotlinx/serialization/internal/SerializationConstructorMarker;,(ILkotlinx/datetime/Instant;ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V,getTimestamp,()Lkotlinx/datetime/Instant;,getStatus,()I,getError,()Ljava/lang/String;,getTrace,getMessage,getPath,component1,component2,component3,component4,component5,component6,copy,equals,,other,hashCode,toString,write$Self,,self,output,Lkotlinx/serialization/encoding/CompositeEncoder;,serialDesc,Lkotlinx/serialization/descriptors/SerialDescriptor;,write$Self$protocol,$serializer,Companion,protocol)```

</p>
</details> 

- Update Gradle to 9.1.0
- Update spring to 3.5.6
- Use Gradle Version Catalogs for plugins
@DRSchlaubi DRSchlaubi changed the base branch from master to dev September 24, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant