-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Chore: Sync fuzzer: Add new possible actions: Adding and syncing a new temporary client on an existing account #12741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
personalizedrefrigerator
wants to merge
19
commits into
laurent22:dev
Choose a base branch
from
personalizedrefrigerator:pr/server/fuzzer/sync-new-client
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
each command This commit is an attempt to improve sync fuzzer performance and work around random failures. It's currently failing after a few steps of the sync fuzzer due to a "Master key not loaded" error.
I'm not sure why this wasn't caught by the linter during commit...
While these changes were useful for debugging a fuzzer failure, they aren't directly related to adding/removing accounts in the sync fuzzer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds actions to the sync fuzzer that allow:
Additionally, to debug issues experienced while working on this pull request, it:
yarn start-no-build --profile=... command-here args-here
". This created one CLI process per command.batch
CLI command to allow accepting input fromprocess.stdin
when ran with-
as the filename. The fuzzer usesbatch -
to send commands to the same CLI process. This allows the web clipper API server to run in the same process as normal CLI commands.Tasks
Fix a conflict-related sync issue — either adjust the fuzzer's expected state or fix the sync bug.dev
.