Desktop: Disable console wrapper #12663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-48
to
-54
| output.warn = function(...text) { | ||
| const s = [...text].join(''); | ||
| // React spams the console with walls of warnings even outside of strict mode, and even after having renamed | ||
| // unsafe methods to UNSAFE_xxxx, so we need to hack the console to remove them... | ||
| if (s.indexOf('Warning: componentWillReceiveProps has been renamed, and is not recommended for use') === 0) return; | ||
| if (s.indexOf('Warning: componentWillUpdate has been renamed, and is not recommended for use.') === 0) return; | ||
| oldConsole.warn(...text); |
There was a problem hiding this comment.
Based on a code search, all usages of componentWillReceiveProps and componentWillUpdate in Joplin's components seem to have been renamed. It's possible that one of Joplin's dependencies still uses them, but I haven't noticed related log output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request disables a wrapper around
console.*methods. This wrapper made it more difficult to determine where error messages came from in the development tools.Does not completely resolve #12451, since the full-page error modals still have incorrect stack traces.